slrtbtfs / graphfind-rs

Library for Finding Patterns in graphs
Apache License 2.0
5 stars 0 forks source link

Add eval function to Subgraph Algorithm trait, making it simpler to use - [merged] #62

Closed slrtbtfs closed 1 year ago

slrtbtfs commented 1 year ago

_Merges apisimplifications -> main

part of #54

slrtbtfs commented 1 year ago

requested review from @bjthehun

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:10

Commented on src/query.rs line 103

Simpler Type is good.

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:10

Commented on src/query.rs line 97

Simplified eval is good. Thanks.

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:13

Commented on src/query_algorithms/vf_algorithms.rs line 508

:thumbsup:

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:14

Commented on src/graph_backends/adj_graphs.rs line 1

Unless you think we may use the adj_graph module later, delete this file.

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:14

Commented on src/graph_backends/adj_graphs.rs line 1

Actually, I will just do that myself.

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:20

Commented on src/graph_backends/adj_graphs.rs line 1

changed this line in version 2 of the diff

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:20

added 1 commit

Compare with previous version

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 2, 2023, 10:23

mentioned in commit 99c9dcd66bf910bda69b7e19ea8390a5e226102e