slrtbtfs / graphfind-rs

Library for Finding Patterns in graphs
Apache License 2.0
5 stars 0 forks source link

More tests - [merged] #65

Closed slrtbtfs closed 1 year ago

slrtbtfs commented 1 year ago

_Merges morecoverage -> main

slrtbtfs commented 1 year ago

great, i managed to write tests that work on my machine but not in the CI environment. @bjthehun does it work on your machine?

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 11, 2023, 16:37

@slrtbtfs All tests work for me. grafik

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 11, 2023, 16:48

I've manually updated our dependencies on my laptop, and nothing has changed. I thought something went wrong with serde/serde_json, but apparently not.

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 11, 2023, 16:54

added 1 commit

Compare with previous version

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 11, 2023, 17:30

Also cleared runner caches. Error still occurs.

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 11, 2023, 17:45

Reading the Rust library docs tells me that if we set a file to read-only with Permissions, we may still write to it under certain circumstances:

https://doc.rust-lang.org/std/fs/struct.Permissions.html#unix-including-macos

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 11, 2023, 18:09

I'm assuming that within our Docker runner, we have superuser rights, so we may write to a file even if it is set as write-only. (This would also why we can just install packages without sudo).

On my machine, I can write to a read-only file as root like this: grafik

slrtbtfs commented 1 year ago

In GitLab by @bjthehun on Feb 12, 2023, 16:47

added 1 commit

Compare with previous version

slrtbtfs commented 1 year ago

ah well, i guess it's easiest to just leave out the test then

thanks for the research!

slrtbtfs commented 1 year ago

mentioned in commit eb9420f482a125d4710414093612c00c8bcb3a53