search

slsa-framework / azure-devops-demo

SLSA Azure DevOps Pipelines Extension
https://marketplace.visualstudio.com/items?itemName=gattjoe.SLSAProvenanceGenerator
Apache License 2.0
23 stars 13 forks source link

chore: use `@tsconfig/node16-strictest` #13

Closed JamieMagee closed 2 years ago

JamieMagee commented 2 years ago

The TSConfig Bases^1 project provides recommended tsconfig.json for almost all TypeScript environments. Azure Pipelines provides a Node.js 16 environment, so the tsconfig/node16-strictest is the most appropriate base template.

Signed-off-by: Jamie Magee jamie.magee@gmail.com

JamieMagee commented 2 years ago

@gattjoe This is going to conflict with #15, but I don't really mind which order you merge them in. Deconflicting is straightforward.

gattjoe commented 2 years ago

Looks like we were hit with https://github.com/tsconfig/bases/issues/74, I was able to manually fix it by using "extends": "./node_modules/@tsconfig/node16-strictest/tsconfig.json" in my test environment.

JamieMagee commented 2 years ago

I think that's because the package.json is not at the root level.