slsa-framework / slsa-verifier

Verify provenance from SLSA compliant builders
Apache License 2.0
216 stars 45 forks source link

feat: VerifyNpmPackage API with supplied tuf client #768

Open ramonpetgrave64 opened 1 month ago

ramonpetgrave64 commented 1 month ago

This PR

Offline rekor verification already works so long as the provenance is a valid sigstore bundle, though we could consider adding an explicit option to enforce offline rekor verifification.

Fixes #493

Testing

Followups

ramonpetgrave64 commented 1 month ago

@slugclub

ramonpetgrave64 commented 1 month ago

This is looking great, thanks so much for working on this. I have a few minor nits but overall it's looking good.

Thanks for the review! I was also looking into logging in https://github.com/slsa-framework/slsa-verifier/pull/772,

ramonpetgrave64 commented 1 month ago

@slugclub thanks again. @ianlewis @laurentsimon , please take a look

haydentherapper commented 2 weeks ago

cc @loosebazooka

ramonpetgrave64 commented 1 week ago

@loosebazooka