Closed ramonpetgrave64 closed 6 months ago
changing the update-dist workflow to use the pr_number input as an env variable to avoid script injection.
pr_number
Our workflows are only invokable by our trusted maintainers so we should be okay. This is just an extra hardening measure.
Open issue https://github.com/actions/runner/issues/1070#issuecomment-2113287699
I confirmed the issue by invoking the workflow with 650 && echo SCRIPT INJECTION, and it did also do the extra echo command.
650 && echo SCRIPT INJECTION
echo
after invoking the workflow again with this PR's version, the problem is mitigated.
@ianlewis @laurentsimon @kpk47
changing the update-dist workflow to use the
pr_number
input as an env variable to avoid script injection.Our workflows are only invokable by our trusted maintainers so we should be okay. This is just an extra hardening measure.
Open issue https://github.com/actions/runner/issues/1070#issuecomment-2113287699
Testing
I confirmed the issue by invoking the workflow with
650 && echo SCRIPT INJECTION
, and it did also do the extraecho
command.after invoking the workflow again with this PR's version, the problem is mitigated.