slsa-framework / slsa

Supply-chain Levels for Software Artifacts
https://slsa.dev
Other
1.48k stars 212 forks source link

VCS and SCP concerns are mixed or too prescriptive #1076

Open TomHennen opened 1 week ago

TomHennen commented 1 week ago
          This section may be mixing concerns between the VCS and the source control platform (SCP). 

Git commit metadata is forgeable from the perspective of the SCP. The SCP typically provides an identity / authz layer which is separate from the git content it manages, and it maintains its own timestamps for when activities happened from its perspective. EG: a commit may claim it was authored last year, but all the SCP knows for sure is that it was uploaded last week.

Authentic contributions will typically be built in terms of the SCP's identity and timestamp models, not the VCS's.

_Originally posted by @zachariahcox in https://github.com/slsa-framework/slsa/pull/1037#discussion_r1588404016_

TomHennen commented 1 week ago

See also this discussion