search

slsa-framework / slsa

Supply-chain Levels for Software Artifacts
https://slsa.dev
Other
1.51k stars 218 forks source link

Enable codeowners restriction for pull request review? #1089

Open TomHennen opened 1 month ago

TomHennen commented 1 month ago

@zachariahcox was asking me if it would make sense to enable a codeowners restriction for pull requests.

It's not really my place to say, so I figured I'd create an issue and see what folks think.

require review from code owners setting

joshuagl commented 1 month ago

Is the goal here to have the tool enforce the policy as documented in CONTRIBUTING? I think one possible barrier is that we have different number of approvers required for different types of content AND one approver might be the person submitting the change:

PR authors with write access to the repo count as second or third approvers for their own PRs

I'm all for having the tooling enforce the requirements if it can.