slu-openGIS / postmastr

R package for Processing and Parsing Untidy Street Addresses
https://slu-opengis.github.io/postmastr/
GNU General Public License v3.0
37 stars 8 forks source link

Converting st names to directions #28

Open Pvp850 opened 1 year ago

Pvp850 commented 1 year ago

Before you open your issue:

Describe the bug Hello, Thanks for this. Let me know if you need more testers. I also have preliminary code set up for apt number matching if you would like that.

Anyways, back to the bug. It correctly converts North to N or East to E and even keeps directions in street addresses as directions, like E 28th st -> E 28th st. But what I found it does in error is convert letter street names to directions. I'm not sure why it does this, but this should not occur. For example: E St -> East St. N Avenue -> North Ave N N Avenue -> N North Ave

Should not occur because there are streets that are N and E streets.

Expected behavior It should keep letter names for sts. E St -> E St. N Avenue -> N Ave N N Avenue -> N N Ave

To Reproduce You can use the examples provided above.


cx2 <- pm_identify(cx2, var = address)

##NEW DATAFRAME CX3 WITH PARSED VARIABLES FOR ADDRESS TO EXTRACT ADDRESS INTO ITS CONSTITUTENT PARTS
cx3 <- cx2 %>%
  pm_parse(input = "short", address = "address", output = "short",keep_parsed="yes",
           dir_dict = dirs, suffix_dict = suff )

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information): Windows 11 R 4.2.2 R studio 2021.09.0 Build 351

Additional context Add any other context about the problem here.