Fluid refactoring - Githubissues

slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.

https://dfg-viewer.de

GNU General Public License v3.0

29 stars 25 forks source link

Fluid refactoring #152

Closed erik-konrad closed 4 years ago

erik-konrad commented 4 years ago

changes fluid inline tags to fluid inline notation for better xml parsing in IDEs and legibility
updates the namespaces and definition to new fluid namespaces for preventing future deprecation warnings and errors

albig commented 4 years ago

Sorry for making extra work but I merged some work from yesterday which causes merge conflicts now with your branch.

I added an requirement for slub/slub-digitalcollections which provides almost all ViewHelpers we use in DFG-Viewer. I don't want to support this code on several places. That's the background.

Could you please adapt your changes to the current master state? KitodoPage.html is quite easy. Pageview.html a bit more.

erik-konrad commented 4 years ago

Okay, now all merge conflicts are solved. I have tested it too. Seems to work all fine.