slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.
https://dfg-viewer.de
GNU General Public License v3.0
29 stars 25 forks source link

Cookies are not set on documents without full-text #187

Closed albig closed 3 years ago

albig commented 3 years ago

In the current release 5.2.0, cookies are not set due to JavaScript errors if the document has no full-text.

Uncaught TypeError: Cannot read property 'split' of undefined
    at dlfViewer.displayHighlightWord (merged-7c58897ed0ac76746819ed3f2a9d1051.js?1621370002:4513)
    at dlfViewer.<anonymous> (merged-7c58897ed0ac76746819ed3f2a9d1051.js?1621370002:4623)

The cookies are used e.g. to save the zoom level.

albig commented 3 years ago

Dear @beatrycze-volk, could you please have a look at this issue? I assume it is a bug in Kitodo.Presentation. Is it only because of a missing configuration? Or because there is no full-text available? Anyway, we should catch this JavaScript exception.

Examples:

working (with full-text):

Error (without full-text, both Kitodo.Presentation 3.2):

If this must be fixed in Kitodo.Presentation, please open an issue there and fix it.

albig commented 3 years ago

Solved by Kitodo.Presentation 3.2.1.