search

slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.
https://dfg-viewer.de
GNU General Public License v3.0
29 stars 26 forks source link

fix character overlap in toc (between caret-down and title) #212

Closed BFallert closed 1 year ago

BFallert commented 1 year ago

before the fix: image

after the fix: image

Example: https://dfg-viewer.de/show/?tx_dlf%5Bid%5D=https%3a%2f%2fdigi.bib.uni-mannheim.de%2foai%2f%3fverb%3dGetRecord%26metadataPrefix%3dmets%26identifier%3d489121969

stweil commented 1 year ago

Yes, they should be rebuilt. Maybe it would be even better to remove generated files like Resources/Public/Css/allStyles.css, Resources/Public/Css/webStyles.css, Resources/Public/Css/rte.css, Resources/Public/JavaScript/allScripts.js or Resources/Public/JavaScript/webScripts.js from git and add them to .gitignore.

csidirop commented 1 year ago

But then they would have to be created manually

stweil commented 1 year ago

Right, developers who use code from git would be forced to build them. But the TYPO3 extension should of course include them and not require an additional build step.

BFallert commented 1 year ago

Sorry I forgot to recreate the CSS file. If generated CSS and JS files are not included, it is a problem for dependent projects where then always remember that the css and js files must be generated manually.

BFallert commented 1 year ago

... Maybe it would be even better to remove generated files ...

In this case you would have to document the necessary development environment, I get an error with npm install with nodejs versions > 17.3.1 for example.