search

slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.
https://dfg-viewer.de
GNU General Public License v3.0
29 stars 26 forks source link

Show provider logo again #221

Closed csidirop closed 9 months ago

csidirop commented 1 year ago

Due to line breaks on xpaths in https://github.com/slub/dfg-viewer/blob/master/Resources/Private/Partials/PageView.html#L62 (and ongoing lines) the provider logo was not shown:

Missing: grafik -> Not missing: grafik

This PR reverts (only) the line breaks from 17bddfc433f111ef8c41ec2078afdde869e27590 to their previous state.

Signed-off-by: Christos Sidiropoulos csidirop@runbox.com

csidirop commented 1 year ago

An other way to reproduce this, is to use our docker images:

  1. Clone repo: git clone https://github.com/UB-Mannheim/kitodo-presentation-docker
  2. Change dir: cd kitodo-presentation-docker
  3. Change branch: git checkout dfg-viewer-dev
  4. Start docker container: docker compose up
  5. Wait till everything is up
  6. open: localhost and use any of the examples or use your own METS file, e.g.: http://localhost/viewer?tx_dlf[id]=https%3A%2F%2Fdigi.bib.uni-mannheim.de%2Ffileadmin%2Fvl%2Fubmaosi%2F59088%2F59088.xml
stweil commented 1 year ago

Ping?

csidirop commented 11 months ago

Any questions regarding this PR?