search

slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.
https://dfg-viewer.de
GNU General Public License v3.0
29 stars 26 forks source link

Rename cofiguration for tools to match changes in Kitodo Presentation #235

Closed beatrycze-volk closed 9 months ago

beatrycze-volk commented 11 months ago

This PR is a fix for problem reported here: https://github.com/kitodo/kitodo-presentation/issues/994

stweil commented 11 months ago

@csidirop, please test this fix. @beatrycze-volk, maybe you want to fix the typo in the commit message.

csidirop commented 11 months ago

I must be doing something wrong because I don't see any change. I merged #235 and #234 into master, flushed caches and did a full site reload.

Did I missed something?

Sitenote: I tried this in our Docker environment, so that I have a clean state for my tests.

beatrycze-volk commented 11 months ago

I must be doing something wrong because I don't see any change. I merged #235 and #234 into master, flushed caches and did a full site reload.

Did I missed something?

No, you have done everything right. I have pinpointed the problem. There is still one more PR (https://github.com/slub/slub_digitalcollections/pull/51) which needs to be merged.

It looks that this exact template is actually not contained in DFG-Viewer but instead it comes from SLUB Digital Collections:

template

Again thank you for your help :) I had this change already on my test system and because of that I thought that this part is already merged in slub_digitalcollections.

csidirop commented 11 months ago

Okay thanks! I'll test it tomorrow.

csidirop commented 11 months ago

Works fine again! Thanks :)