Open csidirop opened 8 months ago
Thanks for your work!
Here you can see how should like corrected version for errors mentioned by PHPStan: https://github.com/slub/slub_digitalcollections/pull/62/files#diff-15fcbab3d3cc1b4c3b8bc8a6b789d6da89d5a731cebdb8929b49fec8de86dcac
I will look for some examples of 3D Viewer and Calendar, then write you back again.
As proposed in #253, this draft intended to remove the dependencies on slub_digitalcollections.
I removed every trace and reference to the digitalcollections and where needed set new paths that lead within the repo. Than I copied missing files and updated some already existing. I tried to compare the commit dates and check it its working because I wasn't sure with the typoscript. For future reference: digitalcollections state at this moment is following commit https://github.com/slub/slub_digitalcollections/commit/d511e7ebdddba4b9ea344eba5e5b311eb1e41c16. I did not copy the history. That exceeded my capabilities and I didn't want to spend hours going through and cleaning up commits. Hopefully this is okay. Btw. we should take a look at the licences, because some of the files have a copyright notice.
At this moment everything I've tested is working fine. Which does obviously not mean that I didn't miss a lot or broke something!
Working:
What's not working:
Happy to get feedback and am looking forward to your corrections