Grunt action to verify if compiled files are up to date

slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.

https://dfg-viewer.de

GNU General Public License v3.0

29 stars 25 forks source link

Grunt action to verify if compiled files are up to date #261

Closed csidirop closed 10 months ago

csidirop commented 10 months ago

This PR adds a GH workflow to check whether the compiled files are up to date with their sources.

It can easily happen that we commit code without grunt running, or merge a PR that is not up to date with master. This GH workflow causes the test to fail in such a case and you can do it afterwards.

beatrycze-volk commented 10 months ago

Thanks for your work!

Could you updated this PR so the newly introduced check actually pass?

csidirop commented 10 months ago

I had actually left the files as they were and not updated them so that you can see the case directly when it fails :D

But updated it now!

csidirop commented 10 months ago

One more thing: I have set node.js to version 12, but you can add more versions to test additionally. (eg. node-version: [12.x, 14.x, 16.x]) In my tests this did not lead to any different results.