search

slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.
https://dfg-viewer.de
GNU General Public License v3.0
29 stars 26 forks source link

Fix missing icons and wrong styling for download menu #262

Closed csidirop closed 7 months ago

csidirop commented 7 months ago

This PR fixes some missing icons and corrects the styling for the imagedownloadtool and fulltextdownloadtool:

grafik The fulltextdownloadtool missed an icon if there was no fulltext.

grafik The imagedownloadtool had no icon at all. So I reused one which belongs to the pdf page download button. Furthermore it fixed the opacity.

And in the doublepageview: all

As you can see, for some reason the imagedownloadtool had a second ::before element and was wrapped in a span. I was not able to find the reason for the existence of the second element, so maybe it was mistake? I have tried to work around the problem, at least for now, by hiding it and moving the text. Only drawback is that in the doublepageview the download for the second page image is now missing all ::before elements.

What do you think?

Also I left both tools active. I thought that since DFG-Viewer is a reference implementation, it should also show what it can do by default. But thats only my opinion and can be easily undone.

csidirop commented 7 months ago

In addition to this changes, this PR https://github.com/slub/slub_digitalcollections/pull/65 fixes the page pdf icon