Update generated CSS and JS files

slub / dfg-viewer

The DFG Viewer is a free web service for browsing digitized books from remote library repositories in a rich and dynamic environment.

https://dfg-viewer.de

GNU General Public License v3.0

29 stars 25 forks source link

Update generated CSS and JS files #291

Closed sebastian-meyer closed 1 month ago

sebastian-meyer commented 1 month ago

Add dependency grunt-cli to Build/package.json
Update dependencies in Build/package-lock.json
Use node.js 20.x for grunt workflow
Update generated CSS and JS files (running grunt less & grunt terser)

This completes PR #230.

sebastian-meyer commented 1 month ago

@gnuj I did the npm update magic, but the GruntComparison build still fails. Do you have an idea what could be wrong here? Is it maybe the old Node.js version (12)?

stweil commented 1 month ago

Grunt 1.6.1 (in your package-lock.json) requires Node.js 14 or later.

stweil commented 1 month ago

It seems to work with Node.js 18, but then creates a different Resources/Public/Css/allStyles.css.map (see https://github.com/slub/dfg-viewer/actions/runs/10044988488/job/27761266962?pr=293).

sebastian-meyer commented 1 month ago

Finally! Thank you for your assistance, @stweil!

sebastian-meyer commented 1 month ago

GitHub doesn't allow reviewing my own PRs and also doesn't allow me to merge this without a review. Could you please have a look at this when you are back in office, @beatrycze-volk?

gnuj commented 1 month ago

Good work! 👍 I also dug a little deeper yesterday and found one or two other NPM issues, which also would be solved by raising the node.js version. So no additions from my side.

beatrycze-volk commented 1 month ago

@stweil and @sebastian-meyer thank you for solving this problem :)