search

slub / ocrd_manager

frontend for ocrd_controller and adapter towards ocrd_kitodo
MIT License
10 stars 3 forks source link

Can we use dos2unix instead own implementation here #11

Closed markusweigelt closed 2 years ago

markusweigelt commented 2 years ago

@bertsky https://github.com/markusweigelt/ocrd_manager/blob/668d2305525e6ad91e2b7b59891ec105d86b37af/for_production.sh#L72

bertsky commented 2 years ago

What do you mean dos2unix?

markusweigelt commented 2 years ago

I suspected here that this replacement takes place to avoid certain windows characters but it is general and has nothing to do with it. :-/

I think since the workflows are written independently of the linux system it can come to problems at this point when CR LF newlines are not converted.

bertsky commented 2 years ago

I think since the workflows are written independently of the linux system it can come to problems at this point when CR LF newlines are not converted.

Yes, to make this compatible with the DOS/Windows EOL convention, you need #12