search

slub / ocrd_manager

frontend for ocrd_controller and adapter towards ocrd_kitodo
MIT License
10 stars 3 forks source link

for_production: validate tasks before running them #16

Closed bertsky closed 2 years ago

bertsky commented 2 years ago

(validation must run on target=controller, because tools are only installed there – so we should probably rename pre_process_validate_workflow to ocrd_validate_workflow)

bertsky commented 2 years ago

BTW, we could also use ocrd validate tasks --overwrite / ocrd process --overwrite to allow incremental jobs (re-entry). Not sure if this is what we want, though.

markusweigelt commented 2 years ago

Ok feel free to rename this function in this context. My initial assumption was that we validate it via a second ssh request. It is much better that way.

markusweigelt commented 2 years ago

I think we should add a specific issue for this incremental jobs feature to be able to evaluate this at a later time.

bertsky commented 2 years ago

Yeah, a second SSH request would work, too. But since we implicitly connect everything conjunctively already (by set -e), I think it's better that way. (Once we start restricting jobs on the controller, it would be easier to have everything in a single call.)