search

slub / ocrd_manager

frontend for ocrd_controller and adapter towards ocrd_kitodo
MIT License
11 stars 3 forks source link

process_images.sh: allow skipping workspace validation #61

Closed bertsky closed 1 year ago

bertsky commented 1 year ago

needed as a stopgap measure; currently needed because we must wait for adoption of https://github.com/OCR-D/core/pull/1066

markusweigelt commented 1 year ago

Don't you think it's a better way to customize the global function post_validate_workdir in the file ocrd_lib.sh than in any implementation file or do you see the ocrd_lib.sh as a snippet library without "logic"?

bertsky commented 1 year ago

Don't you think it's a better way to customize the global function post_validate_workdir in the file ocrd_lib.sh than in any implementation file or do you see the ocrd_lib.sh as a snippet library without "logic"?

I do see ocrd_lib.sh as a library of sorts. If we wanted to differentiate various validation options, then we should indeed handle this inside ocrd_lib.sh, but for the moment I don't see the need (and validation can get quite complex, so OCR-D should IMO encapsulate all of it).

markusweigelt commented 1 year ago

needed as a stopgap measure; currently needed because we must wait for adoption of OCR-D/core#1066

After merge we must surely adapt our script in Kitodo.Production as well?

bertsky commented 1 year ago

After merge we must surely adapt our script in Kitodo.Production as well?

No, IMO it's enough to wait for the next ocrd_all release, since I have fixed the remaining processors now, they just need to be merged (which will likely happen sooner than our users updating their Kitodo).