bug fixes and more - Githubissues

slub / ocrd_monitor

Web frontend for ocrd_manager

MIT License

2 stars 3 forks source link

bug fixes and more #24

Closed bertsky closed 1 year ago

bertsky commented 1 year ago

process_id must be a str not an int, esp. for process_mets.sh
active job status must use PID from $REMOTEDIR/ocrd.pid (on Controller), not from $PID (on Manager)
add missing job status D
jobs: show (and sort by) time created/terminated
use /workflows volume
active jobs: add kill button (dummy for now)

bertsky commented 1 year ago

needs https://github.com/slub/ocrd_manager/pull/57

bertsky commented 1 year ago

add kill button (dummy for now)

@SvenMarcus to implement this, we would need to "log in" to the Manager and kill the given process ID. But I don't like the Monitor to hold the keys. Perhaps we should instead start implementing our minimalistic web server in the Manager itself – delegating to for_production.sh, for_presentation.sh (which we will need for new jobs anyway) and to the killer.

Sry, I'll update the CI tests shortly.

markusweigelt commented 1 year ago

All right thanks. When the pytest problem is solved I give my approve.