search

slugbucket / crossword-hints

Python Flask web application to aid decipherment of cryptic crossword clues for known setters
GNU General Public License v3.0
1 stars 0 forks source link

Add a close button to the solution types modal dialog - feat0032 #33

Open slugbucket opened 4 years ago

slugbucket commented 4 years ago

Add a close button to the modal dialog on the solutions form similar to what is shown at https://www.w3schools.com/Bootstrap/bootstrap_ref_js_modal.asp. Note that the ESC key doesn't work to exit the dialog.

slugbucket commented 4 years ago

Based on https://www.w3schools.com/howto/howto_css_modals.asp add a form element

<div class="modal-footer">
          <button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
        </div>

with appropriate styling,

/* Modal Footer */
.modal-footer {
  padding: 2px 16px;
  background-color: #5cb85c;
  color: white;
}
slugbucket commented 4 years ago

The suggested approach doesn't work as expected and doesn't really add anything to the overall look so it's debatable whether it is actually worth implementing this.