slugbyte / lackluster.nvim

a delightful and customizable mostly monochrome colorscheme thats soft on the eyes and supports treesitter, lsp, and heaps of neovim plugins.
MIT License
194 stars 11 forks source link

Undercurl #48

Closed vadymbiliuk closed 3 months ago

vadymbiliuk commented 3 months ago

Hi. I'm enjoying your theme so much. But i didn't understand if there is possibility to turn on undercurl. Can you please support me with that?

slugbyte commented 3 months ago

So glad you are enjoying the theme! I'd be happy to help ya, but I need some more clarification :)

Currently the theme only has undercurl enabled for spelling error related highlights, are those showing up for you?

I think some other themes turn on undercurl for diagnostics, is that what you are looking for?

If so i would be happy to add support!

If you are looking for undercurl support in a different way than spelling or diagnostics, please let me know :)

slugbyte commented 3 months ago

Also I am curious what terminal are you using, and if you using tmux?

vadymbiliuk commented 3 months ago

I think some other themes turn on undercurl for diagnostics, is that what you are looking for?

I do look for diagnostics

Also I am curious what terminal are you using, and if you using tmux?

Kitty, no tmux. I have that for kitty.conf: enable_kitty_graphics yes And i had working curly underlines with github theme. Since i like this a lot i just need a few tweaks :)

Currently the theme only has undercurl enabled for spelling error related highlights, are those showing up for you?

I don't have configuration for that type of stuff so i cannot tell unfortunatelly

slugbyte commented 3 months ago

I will try to add support for undercurl in diagnostics sometime tomorrow :)

-- set this in your lua config to enable spell checking 
vim.opt.spell = true
vadymbiliuk commented 3 months ago

Thanks!

slugbyte commented 3 months ago

added undercurl support for diagnostics (PR #49)

undercurl should be enabled by default if you update lackluster

(optional) I also decided that i prefer underline, so I added a tweak_ui section to the setup() config and you can set disable_undercurl = true to use underline instead of undercurl

Let me know if you still have any issues :)

vadymbiliuk commented 3 months ago

No issues, looks brilliant