bug: WhiteSpace / NonText color not handeled

[psynyde]

Did you check docs and existing issues?

• [X] I have read all the docs
• [X] I have searched the open and closed issues
• [X] I have added screenshots if relevant

Whats your neovim version?

v0.9.5

Operating System

nixos btw :p

Describe the bug

Expected Behavior

as the title suggests, whitespace character isn't handled. So it kinda looks out of place as shown in the 1st window and the 2nd one is somewhat expected.

Additional context

No response

[psynyde]

while we're at it i think FloatBorder highlight also could be something better. This is with default pallet:

This is with Floatborder guibg=#101010:

[slugbyte]

@PsyNyde thanks for the bug report!

For the whitespace bug, Did you find a specific highlight that fixed your whitespace issue, I'm not able to reproduce on my setup.

For the border feature suggestion: I'm a fan of borderless popups, but I'm willing to add an setup() toggle to add visible borders for popups :)

I'm afk for the next two days, but can probably get to this Wednesday evening :)

[psynyde]

For the whitespace bug, Did you find a specific highlight that fixed your whitespace issue, I'm not able to reproduce on my setup.

to reproduce the issue you'll need

vim.opt.list = true
vim.opt.listchars = { tab = "» ", trail = "·", nbsp = "␣" }

these options to be set. for list the highlight group is literally called WhiteSpace which is by default links to NonText highlight group. So defining NonText should suffice the issue. You can search them using :Telescope highlights if necessary.

For the border feature suggestion: I'm a fan of borderless popups, but I'm willing to add an setup() toggle to add visible borders for popups :)

Changing the highlight shouldn't enable border for non border users. border visibility is managed through plugin specific settings for example

window = {
    completion = cmp.config.window.bordered(),
    documentation = cmp.config.window.bordered(),
},

in cmp-nvim this enables border regardless of any highlight. I was just making sure if FloatBorder is used elsewhere where changing this could negatively effect its visually.

I'm afk for the next two days, but can probably get to this Wednesday evening :)

i'd have send a pr but unfortunate i got exams next month :( although i fixed mine through vim cmd (as seen in the code in border issue screenshot) for now so no rush from my part

[slugbyte]

@PsyNyde Thanks for the thorough response, that's exactly the information I needed! I should be able to patch all this tomorrow :)

Good luck with exams!

[slugbyte]

I closed the issuer because I just merged a PR that patches this bug, now NonText is Gray5 and Whitespace is Gray4

I also created a new suggestion issue to track the float boarder proposal :) I'll try and have a PR merged to adress this in the next week :)

Thanks again @PsyNyde for bringing this issue to my attention! :)