Closed lucat1 closed 6 years ago
Removed netlify checks.
🔥 WARNING TO SELF 🔥
Really interested in implementing siddharthkp/bundlesize with this since bundle size and speed are one of our major concerns
SSR and ThemeProvider
fixed over the course of today. Still, need to rewrite the styles.ts
file, but we're in a good shape right now. APIs won't change so @Gejsi can start converting some packages to TS.
NOTE TO SELF: Implement styled.div
instead of styled('div')
Okay, now that I've converted the grid package to typescript I found that the code is quite dirty. I'll try to beautify it.
The color manipulation scripts are looking great! 🎉
I've finally managed to enable LIVE RELOADING. It was a tough one and required several days of debugging, because of typescript errors with typings. Now that it's working I'll move onto rewriting the last bit of theming and then converting other modules to typescript! 🎉
I've managed to rewrite it without adding bugs or breakage while being able to change a couple of function names and make it more modular! Thanks, typescript! ❤️ 😍
EDIT: Looks like I've added 4bytes overhead while rewriting. Ops🤷🏻♀️
Dropped #23 as an objective since it was going to take way too long. We'll cover it in the next PR along with a proper rewriting and not just conversion to TS
Right now i'm struggling to bundle these packages with a .babelrc
. Hope to fix it soon so this can be merged! 🎉
This PR is finally over! 🎉
Closes #24 Closes #29 Closes #40 Closes #44 Closes #43 (With SSR)