Closed clipcarl closed 7 months ago
Hello, it seems exactly like this one : https://github.com/slurdge/goeland/pull/178/commits
I'm still confused on what is the expected output compared to use the "IncludeLink" filter. Could you show me an example ?
Hello, it seems exactly like this one : https://github.com/slurdge/goeland/pull/178/commits
So it does! I guess someone else beat me to it. I'll close this one then.
Wait ! I still don't understand the goal :-) So I won't merge it until I grasp the best way to achieve what is needed. Please comment either here or on the pull request. Ideally show me a screenshot and/or html of what you want to achieve.
Also, is this the same as https://github.com/slurdge/goeland/discussions/104 ?
The goal is to allow for adding a clickable link to to the original article in the email generated by goeland. It is the same as #178 and #104 .
The documentation suggests that IncludeLink only works when generating digests. I wish to add the link when not using digests.
Ah ! So you mean, take a source, have one email per entry, and each entry has the link back to the website ? Basically, let's say 10x the emails, and each <h1>
has a link right ?
If so I think I can make inclueLink work all the time.
So you mean, take a source, have one email per entry, and each entry has the link back to the website ?
Yes. One generated email for each RSS article and the generated email has a link to the full article.
... each
<h1>
has a link right ? If so I think I can make inclueLink work all the time.
I customize the style of the link and its placement in the email's template so if IncludeLink automatically adds something like <h1>
that wouldn't work for me. Also I'm not sure if IncludeLink would allow for customizing the location of the link in the email which I also do.
My preference would be to have #178 even if you do change IncludeLink.
Thanks!
if IncludeLink automatically adds something like
<h1>
that wouldn't work for me.
Yeah that would do exactly that.
My preference would be to have https://github.com/slurdge/goeland/pull/178 even if you do change IncludeLink.
I understand. I'll merge the PR but not the bit that changes the default template.
Also, if you have nice email templates, feel free to share them, I'm always hoping to add more.
Done in v0.18.0
Thank you!
The attached huge and complicated patch adds a URL variable for use in the email template to allow for adding a clickable link to to the original article like so:
Patch:
goeland-add_url_var.patch.txt