slurpcode / slurp

One repo to rule them all !!?!?!! 🤓 😎
https://slurp.rtfd.io/
GNU General Public License v3.0
53 stars 76 forks source link

added a lite option to remove content #2785

Closed Dxuian closed 1 month ago

Dxuian commented 1 month ago

in reference to #2393 added a discard content boolean option

BaseMax commented 1 month ago

Hey, John need to take a look and review your merge request. He will it soon but not today.

Thank you so much for your contribute. Feel free to improve it as much as you can. John is a special man.

BaseMax commented 1 month ago

Hi there, happy to see you are helping to the project. It's great.

You need to do some changes, then we can approve and merge your changes.

You needs to remove "content" from the results array. you has the test for the "lite" version. Lite version does not include content. It is not the best approach but helps and we can modify later. Can you please results array needs no content for the lite version?

Dxuian commented 1 month ago

Hi there, happy to see you are helping to the project. It's great.

You need to do some changes, then we can approve and merge your changes.

You needs to remove "content" from the results array. you has the test for the "lite" version. Lite version does not include content. It is not the best approach but helps and we can modify later. Can you please results array needs no content for the lite version?

as asked ive removed content from the new code and enhanced the old code please review and merge 🙏🙏🙏

BaseMax commented 1 month ago

Thanks.

Dxuian commented 1 month ago

@jbampton please merge and close🙏🙏🙏

johnbampton commented 1 month ago

Thanks and well done.

I tested locally and it seems to work fine.

Ready for approval and then merge

On Sun, 6 Oct 2024 at 23:27, Dxuian @.***> wrote:

@jbampton https://github.com/jbampton please review and merge 🙏🙏🙏

— Reply to this email directly, view it on GitHub https://github.com/slurpcode/slurp/pull/2785#issuecomment-2395440627, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3LEGW2UWIO7RD73XMRMIDZ2E3FDAVCNFSM6AAAAABPMKI2ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQ2DANRSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

BaseMax commented 1 month ago

Many thanks and well done