search

slurpcode / slurp

One repo to rule them all !!?!?!! 🤓 😎
https://slurp.rtfd.io/
GNU General Public License v3.0
53 stars 76 forks source link

Fix markdown link check #2804

Closed Dxuian closed 1 month ago

Dxuian commented 1 month ago

regarding #2480

fixes #1862

refs #344

Dxuian commented 1 month ago

@johnbampton @BaseMax okay so there's nothing wrong with the link checker the problem seems to be in the fact that the links it tries to check are actually dead or behind a 301, 302, 307, and 308 redirect the solution to this should be removal of dead links and accommodation of redirects

Dxuian commented 1 month ago

403 codes are also present in some links that work

Dxuian commented 1 month ago

i've looked up the GitHub action and looks like there's a alternative to it so i will be trying that one

Dxuian commented 1 month ago

i've looked up the GitHub action and looks like there's a alternative to it so i will be trying that one

looks like the alternative isnt fully built so its better to stick to this

Dxuian commented 1 month ago

@johnbampton @BaseMax can you add hacktoberfest label to this issue please 🙏🙏🙏🙏🙏🙏

Dxuian commented 1 month ago

@johnbampton the test passes now please review

Dxuian commented 1 month ago

@jbampton done please review

Dxuian commented 1 month ago

@johnbampton i made a change please review and merge, the test works fine now

Dxuian commented 1 month ago

@jbampton the test works fine now can we merge and close this #1862 and #2480

Dxuian commented 1 month ago

@jbampton any other changes?

Dxuian commented 1 month ago

@jbampton any changes?

Dxuian commented 1 month ago

@johnbampton @BaseMax it passes all tests can you merge and close issue

jbampton commented 1 month ago

Hey @Dxuian can you please comment on this issue to say you want it ?

https://github.com/slurpcode/slurp/issues/1862

Dxuian commented 1 month ago

@johnbampton it passes the link test now pls review

Dxuian commented 1 month ago

the test is failing again lemme see

Dxuian commented 1 month ago

since dir exclusion isnt possible i have found a alternative to this action its basically the newer version of the old one so im going to experiment with the new one

Dxuian commented 1 month ago

since dir exclusion isnt possible i have found a alternative to this action its basically the newer version of the old one so im going to experiment with the new one

the tool is still incomplete reverting to old one

Dxuian commented 1 month ago

@johnbampton pls review

Dxuian commented 1 month ago

@johnbampton ive managed to fix pre-commit errs also

Dxuian commented 1 month ago

@johnbampton any changes ?

BaseMax commented 1 month ago

?