Open jbampton opened 4 years ago
refs #599
Category: Music -> New Retro Wave -> first logo in issue #142
https://www.youtube.com/channel/UCD-4g5w1h8xQpLaNS_ghU4g
So it seems there is no exact Wikipedia link. So we need some liquid markup changed. And we need the CSV to be updated with a new column. We have all the code already.
Look at the 'Games' concept ->
https://github.com/slurpcode/slurp/blob/master/docs/_data/games.csv
https://github.com/slurpcode/slurp/blob/master/docs/pages/games.html
It links to YouTube instead of Wikipedia.
Adding logos
From root of the repo you would install the gems
via -> bundle install
Logos go on the Fuchsia site in the right category.
The site runs Jekyll, in the 'docs' folder.
cd docs; ./run.sh;
to test locally. Or since you are on windows you can test locally from the 'docs' folder by running:
cd docs; bundle exec jekyll serve
For example the 3rd logo in the issue -> https://github.com/slurpcode/slurp/issues/142
is from the program -> The Walking Dead, So that would go in the TV category.
For example you can see the television.html page here -> https://github.com/slurpcode/slurp/blob/master/docs/pages/television.html
Most likely you won't have to touch that page. That page comprises of Liquid Markup.
https://shopify.github.io/liquid/
So you would add the logo 'details' the CSV data file here -> https://github.com/slurpcode/slurp/blob/master/docs/_data/tv.csv
Insert the logo at the top of the CSV so that it shows up first
Jorge has done most of those logos so the 'designer' column would be blank. 'H' is for Harley.
We link all logos to their Wikipedia page via the 'name' column.
So we have over 300 logos.
So your logo would go in this folder -> https://github.com/slurpcode/slurp/tree/master/docs/assets/images/tv
We number the logos so we have to get the highest or latest one
All the logos must also go here -> https://github.com/slurpcode/slurp/tree/master/docs/assets/images/logos
So the last one was....
329 ?
Once you add a few logos it will be easy.
So if you add "The walking dead logo" it would be number 330
And then you must also update the gallery page with 330 in the for loop here -> https://github.com/slurpcode/slurp/blob/c5db5ae43985dacd86af1684bb992327dc982b88/docs/pages/gallery.html#L8
Then I think the last thing is to update start js here -> https://github.com/slurpcode/slurp/blob/c5db5ae43985dacd86af1684bb992327dc982b88/docs/assets/js/start.js#L3 to 331
Have a quick look here -> https://jekyllrb.com/