search

slushjs / gulp-conflict

Check if files in stream conflict with those in target dir, with option to use new, keep old, show diff, etc.
MIT License
22 stars 12 forks source link

Replacing File gives message "Keeping File" #2

Closed tybruffy closed 9 years ago

tybruffy commented 10 years ago

Title says it all I think? If I opt to replace my file, the next message says it is keeping that file. Seems a little confusing to me. Shouldn't it say "Replacing" instead?

mgan59 commented 9 years ago

yeah just ran into this as well and was confused on what was happening till I came here to see if there was an issue and to look at the code.

For me what is confusing is the generator I wrote to create the file should indicate it was 'created/replaced'. Just saying 'Keeping File' makes no sense to me.

joakimbeng commented 9 years ago

The message refers to keeping the file in the stream, which will replace the file in the destination folder.

I would happily accept better/clearer messages in a PR :)

mgan59 commented 9 years ago

Opened a PR and think my message helps clarify the context. Open to feedback so we get the messaging right.

mgan59 commented 9 years ago

@tybruffy I did some inline comments on the PR let me know your thoughts on the messaging.

joakimbeng commented 9 years ago

Solved by #3