slushjs / gulp-install

Automatically install npm and bower packages if package.json or bower.json is found in the gulp file stream respectively
MIT License
106 stars 46 forks source link

.on('finish') fires before `npm install` concludes #11

Closed UltCombo closed 10 years ago

UltCombo commented 10 years ago

Wait, that looks like the correct behavior -- finish fires once the writable part of the through stream has finished, which is before the through stream returns the readable stream output. So I believe the correct event to listen in the Slush.js docs would be 'end', though then one has to drain the readable stream I believe.

UltCombo commented 10 years ago

Moved to https://github.com/slushjs/slush/issues/20