slushjs / gulp-install

Automatically install npm and bower packages if package.json or bower.json is found in the gulp file stream respectively
MIT License
106 stars 46 forks source link

Break on error #12

Closed floatdrop closed 9 years ago

floatdrop commented 9 years ago

Why gulp-install do not break on error, when bower/npm fails - https://github.com/slushjs/gulp-install/blob/master/index.js#L46 ?

If dependencies are not installed, what is the point to continue build?

elkwood commented 9 years ago

Running into a problem with some builds when npm install fails. Now our CI has broken builds that were thought to be successful. Merge please.

floatdrop commented 9 years ago

@mcdermed since gulp-install is used inside generator, it copies behaviour of Yeoman. I think it will not be merged as is. Meanwhile you can use gulp-start for same purposes.

joakimbeng commented 9 years ago

Fixed by #13