search

slushjs / slush-angular

A slush generator for AngularJS using the Google Angular App Structure Recommendations
129 stars 32 forks source link

Added .bowerrc file #1

Closed pashaie closed 10 years ago

pashaie commented 10 years ago

Default path for bower_components is /app/bower_components, but gulp bower files tries to read from /bower_components. This change sets bower_components path to /bower_components

joakimbeng commented 10 years ago

How do you get a default path of /app/bower_components? It defaults to /bower_components for me already.

Also, according to the Bower homepage:

All package contents are installed in the bower_components directory by default.

So this shouldn't be necessary.

pashaie commented 10 years ago

I've a semi clean Ubuntu vm that I use for angular development. I have yeomen, bower, grunt. But my default bower_components was /app/bower_components and I have certainly not changed that. I'm not quite sure when and where it has changed to /app/bower_components. maybe some node package has changed it.

Anyway, I think it could be a good idea to set (reset) bower_components path to /bower_components by .bowerrc.

e-oz commented 10 years ago

@pashaie generator-angular use /app/bower_components as default.

pashaie commented 10 years ago

@jamm thanks for heads up. so, beside being a good idea to set (reset) bower_components path, it's necessary for guys that already have installed yeoman.

joakimbeng commented 10 years ago

@pashaie no it shouldn't be. That is only if you've used yeoman with generator-angular to scaffold a project, and then use slush-angular in the same directory. In that case I think you should remove the existing .bowerrc file first.

pashaie commented 10 years ago

The thing is, you got me wrong. I wasn't using slush-angular in an old folder that I used yeoman in it. No, that's not the case here. As I said before, I've a semi clean Ubuntu virtual machine that I use for front-end development using angular. No fancy stuff, no poking around yeoman, just, you know, regular stuffs. Then I heard about slush-angular from dailyjs, and because I hate grunt, thought I'll give it a try. So I installed gulp, slush and slush-angular and creating a NEW folder, I got error regarding bower path. After some debugging I find out that my bower path is /app/bower_components. So if you are absolutely sure that bower path is always set to /bower_components and under no circumstance it will ever change, then forget about this PR.

joakimbeng commented 10 years ago

Sounds really weird. But as you say it wouldn't heart to add the .bowerrc file with bower_components as the default folder. So I'll merge this!

joakimbeng commented 10 years ago

The new 0.2.0 release contains this PR.

pashaie commented 10 years ago

Thanks. Sorry for my tone in previous comment. I know I must descried the problem in an issue, and then with reference to it, PRed this commit.