search

slushjs / slush-angular

A slush generator for AngularJS using the Google Angular App Structure Recommendations
129 stars 32 forks source link

`dist` task does not inject index.html #25

Closed cakesmith closed 9 years ago

cakesmith commented 9 years ago

It seems that the dist task does not execute the function to inject the minified vendor files into ./dist/index.html. After removing the vendors task from the dependency list on the dist task, the function then executes, confirming the source of the problem. I think this has something to do with the event streams being processed in the vendors task, which quietly exits without returning. I'm not sure how to get the vendors task to execute and also have the rest of the dist task complete.

cakesmith commented 9 years ago

Side note: I think this may have something to do with how I've included bower components into my project. It seems to work with a clean slush angular install, so I'm going to try to re-create my project that way and see if I can't isolate the problem a bit more.

petermetz commented 9 years ago

@cakesmith I'm struggling with the same problem and narrowed down the problem to Bootstrap. If I remove it from the bower dependencies, my vendors task finishes properly. Despite of all this, I can't get it working.

Did you manage to find a solution?

cakesmith commented 9 years ago

I can't seem to recreate the issue, I started a new app with gulp angular and I haven't run into the vendors issue again. I have angular-bootstrap installed, with bootstrap as a dependency of it, but I do not have bootstrap proper installed in my bower.json. I relegated to using the CDN version of the bootstrap CSS.

petermetz commented 9 years ago

You have to add some more files. For me font-awesome, bootstrap, angular loading bar, foundation did the trick to make it consistently reproducible.

Peter On 5 Aug 2014 18:06, "Nick LaRosa" notifications@github.com wrote:

I can't seem to recreate the issue, I started a new app with gulp angular and I haven't run into the vendors issue again. I have angular-bootstrap installed, with bootstrap as a dependency of it, but I do not have bootstrap proper installed in my bower.json. I relegated to using the CDN version of the bootstrap CSS.

— Reply to this email directly or view it on GitHub https://github.com/slushjs/slush-angular/issues/25#issuecomment-51228033 .

petermetz commented 9 years ago

And you have to make sure that the dependencies are installed via bower because that's how all the vendor files are gathered at the first place, via the bower module. On 5 Aug 2014 18:06, "Nick LaRosa" notifications@github.com wrote:

I can't seem to recreate the issue, I started a new app with gulp angular and I haven't run into the vendors issue again. I have angular-bootstrap installed, with bootstrap as a dependency of it, but I do not have bootstrap proper installed in my bower.json. I relegated to using the CDN version of the bootstrap CSS.

— Reply to this email directly or view it on GitHub https://github.com/slushjs/slush-angular/issues/25#issuecomment-51228033 .