search

slushjs / slush-angular

A slush generator for AngularJS using the Google Angular App Structure Recommendations
129 stars 32 forks source link

Fix for #25 - Swapping out gulp-filter with vinyl-fs for the vendor .css files processing #26

Closed petermetz closed 9 years ago

petermetz commented 9 years ago

Problem: Too many and/or too big .css files bring gulp-filter to it's knees as when collecting .css files for processing, as I found. This makes the 'vendors' gulp task to fail silently, stopping the dependent 'dist' task from executing properly either. The latter manifests as the missing index.html file problem in the referenced issue.

Solution: Use vinyl-fs to grab a stream of the input .css files which appears to be competent enough to handle a bigger laundry too.

A much more decent solution would be to investigate and fix the problem of gulp-filter, but that's out of my scope right now unfortunately.

joakimbeng commented 9 years ago

Fixed by using the Array.filter function instead.. Thanks for the input on this!