slutske22 / react-esri-leaflet

react components for esri-leaflet
https://codesandbox.io/s/github/slutske22/react-esri-leaflet/tree/master/examples/ts
MIT License
37 stars 5 forks source link

Add Support for Esri Leaflet Renderers #7

Closed pmacMaps closed 3 years ago

pmacMaps commented 3 years ago

Are there plans to support Feature Layers utilizing the symbology they are published with?

This is taken care of the Esri Leaflet Renderers plugin in non-React environments.

slutske22 commented 3 years ago

I've never played with that plugin before, but now that I look at it, it seems that as long as the renderers plugin is included in your page /code before any esri-leaflet (or react-esri-leaflet) components get added, the renderers plugin just handles the rest for you. Have you tried this yet? It seems like it should just work out-of-the-box I'm a bit busy today, but if you can test it and let me know what the results are, that would help figure out if we actually need to adjust to code to support this. Otherwise It may take me some time to test it out myself.

pmacMaps commented 3 years ago

It appears that simply adding Esri-Leaflet-Renderers throws an error.

esri-leaflet-renderers-react-error

slutske22 commented 3 years ago

How are you adding it? <script> tag in the HTML header? import 'esri-leaflet-renderers'? Just adding it in shouldn't cause that kind of error. It may mean you're imports of leaflet, esri-lealfet, and esri-leaflet-renderers are not cooperating with each other. Can I see some code?

slutske22 commented 3 years ago

Without seeing some code / attempts to make this work, I'm going to close this issue for the time being.

pmacMaps commented 3 years ago

I am adding it as a Githubissues.

  • Githubissues is a development platform for aggregating issues.