search

slviajero / tinybasic

A BASIC interpreter for Arduino, ESP, RP2040, STM32, Infineon XMC and POSIX with IoT and microcontroller features.
GNU General Public License v3.0
205 stars 32 forks source link

Missing (important) detail in "How to add your own commands" #28

Closed Kongduino closed 2 years ago

Kongduino commented 2 years ago

In How to add your own commands I think you skipped an important step, which is what tripped me while trying to add a command.

In basic.h I see these defines:

/* the number of keywords, and the base index of the keywords */
#define NKEYWORDS   3+19+13+12+11+5+2+7+7+7+12
#define BASEKEYWORD -121

Shouldn't NKEYWORDS be incremented to match the number of total keywords with the one(s) we add? I don't see any mention of this anywhere.

Thanks.

slviajero commented 2 years ago

Until version 1.2. this was needed. Now it is not used any more. I keep it updated more out of tradition to know how many keywords I have added to each language set.

Am 24.08.2022 um 02:31 schrieb Kongduino @.***>:

In How to add your own commands https://github.com/slviajero/tinybasic/wiki/How-to-compile-Stefan's-BASIC-(and-how-it-works)#how-to-add-your-own-commands I think you skipped an important step, which is what tripped me while trying to add a command.

In basic.h I see these defines:

/ the number of keywords, and the base index of the keywords /

define NKEYWORDS 3+19+13+12+11+5+2+7+7+7+12

define BASEKEYWORD -121

Shouldn't NKEYWORDS be incremented to match the number of total keywords with the one(s) we add? I don't see any mention of this anywhere.

Thanks.

— Reply to this email directly, view it on GitHub https://github.com/slviajero/tinybasic/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSY56DEIMEY7QFOE5SGO23V2VUNXANCNFSM57NMXVTQ. You are receiving this because you are subscribed to this thread.

Kongduino commented 2 years ago

Ah thanks, I was still on v1.2!