search

slyrus / opticl

An image processing library for Common Lisp
Other
182 stars 35 forks source link

Thresholding #1

Closed ichernetsky closed 13 years ago

ichernetsky commented 13 years ago

Hi Cyrus,

I've implemented Kittler's thresholding, so you may pull it. In case of any issues with the code, do not hesitate to ask me to fix it.

Thanks.

slyrus commented 13 years ago

Ok, I'm finally getting around to reviewing this. Sorry for the delay! Would you be comfortable removing the line about "public domain" and having the header for threshold.lisp say something like:

;;; Copyright (c) 2011 Ivan Chernetsky, All rights reserved. ;;; See COPYRIGHT file for details.

Also, I can add a message to the COPYRIGHT file about your contribution if you would like.

Thanks!

Cyrus

ichernetsky commented 13 years ago

Hello Cyrus,

Frankly, I do not care about the header. :) That's why I wrote 'public domain' initially. I saw the copyright notice in the other files, but forgot to replace 'public domain' with it in the newly created file. So you may do it, if you would like.

What to do with COPYRIGHT file, is entirely up to you. It's just a mere formality to me.

I await your comments about the code.

Thanks.