search

slyrus / opticl

An image processing library for Common Lisp
Other
182 stars 35 forks source link

Thinning algorithm #3

Closed aluuu closed 12 years ago

aluuu commented 12 years ago

Hi. I made small addition to opticl, it may be useful for some purposes. It works with 1-bit images.

aluuu commented 12 years ago

Oh, it's look like i forgot to add my function to package.lisp.

slyrus commented 12 years ago

Would you mind splitting off the whitespace changes from the thinning functions? I'm OK with whitespace changes, but I'd rather have separate commits for just those. Thanks!

aluuu commented 12 years ago

Ok, i'll fix this tomorrow.

aluuu commented 12 years ago

I made some new commits. They removes whitespace changes at all.

slyrus commented 12 years ago

Hi Aluuu,

Thanks for the changes. Sorry to be a pest about this, but a couple of things:

  1. make-pairs -- this function doesn't seem to exist.
  2. avoiding the revert commit -- one thing I do is to put changes like this on a branch (not master, with just the commits you want in the history) and then I merge the pull request from that. I, of course, can do it from your master branch, but I find pulling from a branch to be slightly easier for me to understand what's going on. If I were to commit as is (roughly, fixing the make-pairs thing, of course :) ) I would then just cherry-pick the commits I want. If you had a clean history, I'd do a merge.

thanks!

Cyrus

slyrus commented 12 years ago

Hey Aluuu,

did you have a chance to look at the problems I mentioned above?

thanks,

Cyrus

aluuu commented 12 years ago

Hi Cyrus,

I'll gonna fix that in a week or two. Just have no time for understanding git branches (i'm newbie at git). Sorry for delay.