slysherz / vscode-comment-box

Extension that transforms lines of text into a pretty comment box.
MIT License
19 stars 2 forks source link

Doesnt take into account width of all text and allign the right comment tags #21

Open dturco-kbx opened 1 year ago

dturco-kbx commented 1 year ago

right side comment tags dont get aligned to the max width

image

slysherz commented 1 year ago

Hey @dturco-kbx thanks for letting me know, I'll look into it. Could you please copy paste the settings you're using? Thanks!

dturco-kbx commented 1 year ago

"commentBox.styles": { "defaultStyle": {}, "yaml":{ "capitalize": false, "ignoreInnerIndentation": false, "ignoreOuterIndentation": false, "removeEmptyLines": false, "textAlignment": "left", "commentStartToken": "##", "commentEndToken": "##", "leftEdgeToken": "# ", "rightEdgeToken": " #", "topEdgeToken": "#", "bottomEdgeToken": "#", "topRightToken": "##", "bottomLeftToken": "##", } },

From: slysherz @.> Sent: Monday, November 14, 2022 9:43 AM To: slysherz/vscode-comment-box @.> Cc: Turco, Dan @.>; Mention @.> Subject: Re: [slysherz/vscode-comment-box] Doesnt take into account width of all text and allign the right comment tags (Issue #21)

Sent by an external sender


Hey @dturco-kbxhttps://urldefense.com/v3/__https:/github.com/dturco-kbx__;!!HKYIif90!xyLJWZFzT0nxDuS42LiQ6g0uS6Xmn-e8IErNv47ZUG0tzWZU0Pa9fzu8ea7k8Gl8z4xozNXJevgUlKIatFIWD2-liUC4_A$ thanks for letting me know, I'll look into it. Could you please copy paste the settings you're using? Thanks!

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/slysherz/vscode-comment-box/issues/21*issuecomment-1313957279__;Iw!!HKYIif90!xyLJWZFzT0nxDuS42LiQ6g0uS6Xmn-e8IErNv47ZUG0tzWZU0Pa9fzu8ea7k8Gl8z4xozNXJevgUlKIatFIWD2-MU4XEaw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A3WR7E4D5G3OXZUWQBSGCF3WIJMZ3ANCNFSM6AAAAAAR76T5LY__;!!HKYIif90!xyLJWZFzT0nxDuS42LiQ6g0uS6Xmn-e8IErNv47ZUG0tzWZU0Pa9fzu8ea7k8Gl8z4xozNXJevgUlKIatFIWD284fFf-Xw$. You are receiving this because you were mentioned.Message ID: @.**@.>>

slysherz commented 1 year ago

Ah, I know what this is, maxEndColumn isn't working as it should. You can work around this by increasing this setting while I work on a fix:

"maxEndColumn": 999
dturco-kbx commented 1 year ago

Awesome ! Thanks

From: slysherz @.> Sent: Monday, November 14, 2022 5:35 PM To: slysherz/vscode-comment-box @.> Cc: Turco, Dan @.>; Mention @.> Subject: Re: [slysherz/vscode-comment-box] Doesnt take into account width of all text and allign the right comment tags (Issue #21)

Sent by an external sender


Ah, I know what this is, maxEndColumn isn't working as it should. You can work around this by increasing this setting while I work on a fix:

"maxEndColumn": 999

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/slysherz/vscode-comment-box/issues/21*issuecomment-1314548304__;Iw!!HKYIif90!wc3yUTdicH54SOGA_VWL43NXepCIVxrYyzzpdbEz27moQWzEmcbqQO9A3-b2P_dBe_3ZL6YFFAiBjA8sfoQrL0pE0hnbEw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A3WR7EY4MRWVTWTO5VR43G3WILEA3ANCNFSM6AAAAAAR76T5LY__;!!HKYIif90!wc3yUTdicH54SOGA_VWL43NXepCIVxrYyzzpdbEz27moQWzEmcbqQO9A3-b2P_dBe_3ZL6YFFAiBjA8sfoQrL0rwFF8j0g$. You are receiving this because you were mentioned.Message ID: @.**@.>>