sm00th / bitlbee-discord

Bitlbee plugin for Discord (http://discordapp.com)
GNU General Public License v2.0
290 stars 27 forks source link

reCAPTCHA causing null input error #118

Open Kyrielight opened 6 years ago

Kyrielight commented 6 years ago

I kept getting the null error when attempting to log into Discord, and a quick debug output shows that login is failing because the reCAPTCHA code section is blank and required (thus returning a 400).

Not exactly sure how this could be bypassed given Discord doesn't like botting into user accounts; I suppose theoretically one could MAC spoof to authenticate beforehand?

sm00th commented 6 years ago

aw snap, they've added captcha now? do you have debug output for this? (remember to remove any passwords/tokens before posting it) I am not getting these atm, but I guess thats because I connect from an ip that is already known

Kyrielight commented 6 years ago

Yep! Here's some output:

HTTP response headers:
HTTP/1.1 400 BAD REQUEST
Date: Wed, 06 Dec 2017 12:14:20 GMT
Content-Type: application/json
Content-Length: 37
Connection: keep-alive
Set-Cookie: __cfduid=(not sure if this is important so I removed it); expires=Thu, 06-Dec-18 12:14:20 GMT; path=/; domain=.discordapp.com; HttpOnly
Strict-Transport-Security: max-age=31536000; includeSubDomains
Via: 1.1 google
Alt-Svc: clear
Server: cloudflare-nginx
CF-RAY: 3c8f2a128e8e6c3a-SJC

Finishing HTTP request with status: 400 BAD REQUEST
[04:14:20] <<< ((null)) discord_http_login_cb [400] 37
{"captcha_key": ["captcha-required"]}

I also tried logging out of Discord and logging back in on several of my devices; they all required me to do captcha sign-in. I also tried to use my server as a SOCK5 proxy + Firefox and logged in successfully, but still received the captcha error, so I'm guessing I would have to spoof to appear to be the application itself.

sm00th commented 6 years ago

So it doesn't work even after a succesfull login from a browser? I wonder why. I thought mine worked because I already had an auth token, but after resetting it biltbee-discord managed to get a new one without an issue.

Kyrielight commented 6 years ago

I'm not quite following you, forgive me; how are you using an auth-token to sign into your account? (I'm just using my email/password since I thought auths are only for bots)

sm00th commented 6 years ago

Discord requires an auth token for every request bitlbee-discord does, so it actually caches the auth token and uses that till it gets invalidated and only after that it sends the credentials to get a new one. My idea was that discord applies captcha to login page only.

rodneyrod commented 6 years ago

It could be set on a per-account basis, maybe too many incorrect logins?

Or worse, it could be the testing phase of a wider rollout.

penny64 commented 6 years ago

Probably should add support for logging in with a token now, it's not hard to get

sm00th commented 6 years ago

Probably should add support for logging in with a token now, it's not hard to get

The option is there, it is just hidden acc off discord acc discord set token_cache xxxxxxxx

Kyrielight commented 6 years ago

Can confirm directly setting the token allows me to log in from any previously unauthorized device. Thanks a bunch guys!

sm00th commented 6 years ago

Let's leave it open since we still have to deal with the capcha somehow. Also people would be able to find the workaround here until the issue is really solved.

mjj29 commented 6 years ago

How do I get a token?

sm00th commented 6 years ago

How do I get a token?

You can login with your browser with "Web Developer"(in firefox)/"Developer Tools"(in chrome) in "network" mode. You should see a POST request to "login" with a response like {"token": "xxxxxxx"}

Kyrielight commented 6 years ago

Chrome's token can also be accessed under Developer Tools --> Application, where under the local storage dropdown, select https://discordapp.com and one of the Key/Value pairs is token/(your token).

sm00th commented 6 years ago

Neat, apparently FF has something similar: Web Developer -> Storage Inspector -> Local Storage -> http://discordapp.com -> token

This is way easier than monitoring "network", thanks.

stevesbrain commented 6 years ago

Thanks for the hint - setting token cache works for me too now :)

blindndangerous commented 6 years ago

Thanks for keeping this open. Would've never figured out what to do without this issue.

PineapplePet commented 6 years ago

Agree. Super thankful!

BlazerHeat commented 6 years ago

there is no token Key in my storage

sm00th commented 6 years ago

you need to login for it to be stored there

zertap commented 6 years ago

At least on firefox, the token only appears for a few moments until discord loads completely. So I had to ctrl+f5 and copy it really quickly before it disappears.

sm00th commented 6 years ago

Looks like discord changed this behavior and it would probably be easier to use the method from my earlier comment https://github.com/sm00th/bitlbee-discord/issues/118#issuecomment-351379422

stevesbrain commented 5 years ago

For other folks looking, if you've got MFA on, it's on the response to the POST to https://discordapp.com/api/v6/auth/mfa/totp (rather than to login) :)

slackhead commented 5 years ago

What is "MFA on"?

I see in that link a method not allowed error. Not sure what/how to affect that in bitlbee.

I've looked at my qutebrowser (chromium based) local storage with sqlite3 and it shows token as X'......' I wasn't sure whether to include the X'' in the token setting, but neither seems to work anyway.

I'm logged in right now in my browser (after having to do a shedload of captchas, and responding to emails), but bitlbee is failing to login. If it matters, I need to use a proxy to connect out and I've set it in the /etc/bitlbee/ conf file. I don't have any other accounts in bitlbee so I can't tell if it's a proxy issue or not.

How can I debug the connection attempts? All I'm seeing is login error. Failed to get info about self.

Chemrat commented 5 years ago

MFA/2FA is multi- or two-step factor authentication, means each client has to be authorized by other means (usually one-time password generated by some other device). It's on your account settings page.

I'm not a developer, but if you have to deal with captchas, bitlbee might not be able to make it past them.

slackhead commented 5 years ago

Ah right. I didn't set up two-factor because I assumed it might involve giving them my mobile number, and nobody gets that apart from some important sites like my bank.

sm00th commented 5 years ago

Hi @slackhead, please see the "Debugging" section at the bottom of README. This will help you get exact requests and responses bitlbee and discord are exchanging.

slackhead commented 5 years ago

Thanks.

OK. I can see a lot of 400 bad requests. There are no messages about captchas in there at all.

About to send HTTP request:
GET /api/gateway HTTP/1.1
Host: https://discordapp.com
User-Agent: Bitlbee-Discord
Content-Type: application/json
authorization: (my token)

This is followed by:


HTTP/1.1 400 Bad Request
Server: cloudflare
Date: Tue, 26 Feb 2019 17:35:41 GMT
Content-Type: text/html
Content-Length: 171
Connection: close
CF-RAY: -

Finishing HTTP request with status: 400 Bad Request
 <<< ((null)) discord_http_gateway_cb [400] 171
<html>
<head><title>400 Bad Request</title></head>
<body bgcolor="white">
<center><h1>400 Bad Request</h1></center>
<hr><center>cloudflare</center>
</body>
</html>```

By the way, neither my password nor login name/email are mentioned in the debug output.
sm00th commented 5 years ago

The password/login won't be used when you have the token set. Are you sure you are using the right token? I think all of the chromium-based browsers should have 'developer tools' and should be able to use the method from comment#18

slackhead commented 5 years ago

I didn't open the dev tools yet. I just looked in ~/.local/share/qutebrowser/webengine/Local\ Storage for a discordapp.com file.

I didn't want to get logged out and then spend another 10 minutes clicking fire hydrants and clicking email links :)

I'll have a look now.

slackhead commented 5 years ago

Well, I found that the token was correct, although it shows something completely different in the inspector.

Anyway I changed the host from https://discordapp.com to just discordapp.com and got a little further.

Now I'm getting 200s back, but in weechat it says 'failed to switch to websocket mode'.

sm00th commented 5 years ago

That one should be accompanied by "switching failure. buf: xxxx" message on debug console that might contain a clue. I actually never tried this through a proxy, that might be a problem.

slackhead commented 5 years ago

I saw in a different issue that the debug output contained a lot of mentions about proxy and other settings, but I don't seem to be seeing any of that, only the http requests and returns. Is there a way of elevating the debugging?

slackhead commented 5 years ago

HTTP response headers: HTTP/1.1 200 OK Date: Content-Type: application/json Content-Length: 35 Connection: keep-alive Set-Cookie: __cfduid= ... HttpOnly Strict-Transport-Security: max-age=31536000; includeSubDomains Via: 1.1 google Alt-Svc: clear CF-Cache-Status: HIT Expires: Cache-Control: public, max-age=30 Accept-Ranges: bytes Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct" Server: cloudflare CF-RAY: xxxxxxxxxxxxxxxx

Finishing HTTP request with status: 200 OK [] <<< ((null)) discord_http_gateway_cb [200] 35 {"url": "wss://gateway.discord.gg"}

I've removed everything sensitive I think.

sm00th commented 5 years ago

The debugging may be either on or off and if you are seeing the 'failed to switch to websocket mode' you should definitely see the other one in debug log since they are right next to each other in sources. It won't be a http request any more but rather a '<<<(null)' type of message.

dequis commented 5 years ago

Another way to get a token with firefox and some commands, first quit firefox and do:

cd ~/.mozilla/firefox/*.default
sqlite3 webappsstore.sqlite
select value from webappsstore2 where originKey = 'moc.ppadrocsid.:https:443' and key = 'token';

You can probably skip the "quit firefox" step if you copy "webappsstore.sqlite" to a different location but when I did that the token wasn't there.

For most people, going to dev tools/storage pane is probably still the easiest way, but the token is very hard to reach with keyboard navigation and screen readers.

(we should maybe have proper documentation and proper error messages for this?)

Alcaro commented 5 years ago

Alternatively, you can skip the 'quit firefox' step if you replace sqlite3 webappsstore.sqlite with sqlite3 file:webappsstore.sqlite?immutable=1, and ensure the database doesn't change while you're running your query.

To do the latter part, type quickly. Or type the query in advance: echo "select value from webappsstore2 where originKey = 'moc.ppadrocsid.:https:443' and key = 'token'" | sqlite3 file:webappsstore.sqlite?immutable=1

fuzzy76 commented 4 years ago

Is this still supposed to work? I found my token, but when I issue account discord on absolutely nothing happens. No error message or anything. I then try chat list discord and it says "Not logged in to account".

sm00th commented 4 years ago

Yes, this still works.

absolutely nothing happens

That doesn't sound right, you should at least see some <@root> discord - Logging in messages. If you don't see these then bitlbee probably didn't get your acc on command.

If you see "logging in" messages but it never succesfully logins you can try following Debugging section from README to gather more info.

fuzzy76 commented 4 years ago
18:44 <@Fuzzy76> account discord on
18:44 <@Fuzzy76> acc discord on
18:44 <@root> Account already online
18:44 <@Fuzzy76> chat list discord
18:44 <@root> Not logged in to account.
18:44 <@Fuzzy76> account discord off
18:44 <@root> discord - Logging in: Signing off..
18:44 <@Fuzzy76> account discord on
18:45 <@Fuzzy76> chat list discord
18:45 <@root> Not logged in to account.
18:45 <@Fuzzy76> account discord off
18:45 <@root> discord - Logging in: Signing off..
sm00th commented 4 years ago

Ok, so I was a bit wrong ant it doesn't report much during login, only if it errors out or successfully logs in. None of the two happens in your log, so it is still in process of logging in or parsing your discord servers.

First of all make sure you are running the latest version of bitlbee-discord because we had issues with login timeouts recently (#201, #202). Then give it a bit more time, you should either see 19:45 <@root> discord - Logging in: Logged in or a time-out error.

fuzzy76 commented 4 years ago

I'm using https://github.com/mbologna/docker-bitlbee which in turn uses 0.4.2 which is the latest.

After waiting a bit it goes like this:

21:26 <@Fuzzy76> account discord on
21:28 <@root> discord - Login error: Connection timeout
21:28 <@root> discord - Logging in: Signing off..
21:28 <@root> discord - Logging in: Reconnecting in 45 seconds..
21:31 <@root> discord - Login error: Connection timeout
21:31 <@root> discord - Logging in: Signing off..
21:31 <@root> discord - Logging in: Reconnecting in 135 seconds..
Alcaro commented 4 years ago

0.4.2 is the latest release, but not the latest commit. 042 was released in december 2018; #202 was fixed this month.

May be time to make a new release?

dgw commented 4 years ago

May be time to make a new release?

Probably. 15 months is a long time! (I say, as if I don't manage a project that's gone longer.)

sm00th commented 4 years ago

Agreed. These changes are important enough to warrant a release so that people won't get confused.

I wonder though why @mbologna chose to fetch 0.4.2 specifically instead of just getting latest git HEAD like with other plugins in docker-bitlbee?

fuzzy76 commented 4 years ago

Probably because it's your newest release. :) Would've been my go to as well. Fetching head from other peoples' repos will sooner or later break your build. I've learnt that the hard way myself.

dgw commented 4 years ago

Fetching head from other peoples' repos will sooner or later break your build.

A Docker-based GitHub action did that to me a few weeks ago, errors popped up because it was fetching the latest (pre-release) revision instead of the last stable. Always fetch tags!

mbologna commented 4 years ago

I wonder though why @mbologna chose to fetch 0.4.2 specifically instead of just getting latest git HEAD like with other plugins in docker-bitlbee?

When the project offers releases, I tend to prefer them over HEAD. And that is why you can find a mix of these approaches when looking at the plugins I included in docker-bitlbee.

The reason is a simple convention: releases should more stable, as HEAD is usually bleeding edge.

sm00th commented 4 years ago

Fair enough. Although with bitlbee-discord being in maintenance mode and me always forgetting to tag new versions it is more likely that relased version will be the one not working. Not trying to change your mind though, thats a good approach in general.

I've tagged 0.4.3 now with said fixes.

fuzzy76 commented 4 years ago

Can confirm it works now :)

chrisleaman commented 3 years ago

Can anyone confirm it is still possible to get the token using the methods listed above? I tried Dev Tools in both Chrome and Firefox, but there doesn't seem to be a token with either method. I have 2FA enabled if that makes any difference...