sm00th / bitlbee-discord

Bitlbee plugin for Discord (http://discordapp.com)
GNU General Public License v2.0
291 stars 27 forks source link

Let's tell what message failed to send #168

Closed Alcaro closed 6 years ago

Alcaro commented 6 years ago

After seeing this error, I've often found myself opening the other client and checking all over for what messages I've sent and whether any is missing (half of the time, it's none of them; discord often delivers the message, but returns some random error over http. I suspect this is what causes all those duplicate messages on the other client).

Let's simplify that by telling which message is relevant.

This doesn't tell what channel it's for, and leaves <@12345678>/etc in there. This can be fixed later, but let's start simple; this is sufficient to allow identifying which message is screwing up and verifying whether it arrived.

(also yes, that strstr is ugly. I'd be glad to replace it with something else, but I couldn't find anything better.)

sm00th commented 6 years ago

One other request before I merge it. Could you please add some description to the commit message (git commit --amend; git push --force)? I know it is available in the pull request but it would be beneficial to have it normal git log as well.

Alcaro commented 6 years ago

Yes sir

sm00th commented 6 years ago

Thanks, merged it.