search

sm00th / bitlbee-discord

Bitlbee plugin for Discord (http://discordapp.com)
GNU General Public License v2.0
291 stars 27 forks source link

Set user real name to untouched nickname #177

Closed dgw closed 5 years ago

dgw commented 5 years ago

Users' true (global) names will be available in WHOIS output and in clients that display real names in the chat view, etc.

This is the result of about an hour (maybe 90 minutes?) reading code, trying to understand how BitlBee and the Discord plugin create/maintain users. I think I ultimately found the right place to do this. It compiled & ran nicely on my test Discord account, on my local system, displaying real names in HexChat with all Unicode characters, whitespace, and other nonsense included. (I joined my test account to a fairly large server with ~200 users, many of whom have Discord usernames that BitlBee currently turns into underscore soup.)

This change technically closes #155, assuming it all checks out. I will next look at changing the reported ident as suggested there, if that's desired, either in this PR or a new one. This has been a good way to dip my toes in the waters of actually working on some BitlBee stuff, and I hope to continue learning.

sm00th commented 5 years ago

Looks good, thank you, merged.

digitalcircuit commented 5 years ago

I just updated and can confirm this works. Thank you very much!

If you decide to tackle it, good luck with adding the Discord tag to ident, too.

dgw commented 5 years ago

I looked into the ident change a bit and discovered it's not quite as easy, haha. I still want to investigate more.