sm0svx / svxlink

Advanced repeater system software with EchoLink support for Linux including a GUI, Qtel - the Qt EchoLink client
http://svxlink.org/
Other
436 stars 173 forks source link

svxlink - ModuleFrn client list #429

Open M0IQF opened 5 years ago

M0IQF commented 5 years ago

Hi, I was using "client FRN" on a server with a lot of other clients, and I've seen an issue. The problem is that the audio cuts while receiving the update client list. It isn't an issue in the RX mode, but then you start transmitting it cuts the modulation and the server goes quiet without tuning the PTT off. Is there a possibility to erase the line of code which is responsible for the receiving the client list in the console mode, which isn't really necessary? P.S: To visualize this issue, you can go to the test room with two clients, and record with one for around 10 seconds. After 5 seconds, log out with one of the clients and listen to the recording. It will only record the first 5 seconds and the remaining 5 will not be recorded, because of the update of the client list.

sh123 commented 5 years ago

@M0IQF, I guess it happens when svxlink sends audio from the RIG into the FRN server. Currently, FRN module goes into the IDLE state after list was processed, thus interrupting audio stream going from rig into the FRN server, list needs to be processed anyway, because the same connection is used for control and audio streams.

Solution might be to save the state if in TX and restore it after list was processed instead of going into the IDLE state or go into the IDLE state only when squelch is closed.

It would be helpful if you post svxlink console log of this issue with FRN module debug level turned on.

I haven't tested it, but workaround might be to replace block in QsoFrn.cpp line 394:

      {
        sendVoiceData(send_buffer, send_buffer_cnt);
        send_buffer_cnt = 0;
      }
      else
      {
        samples_read = count;
        break;
      }

to just

     sendVoiceData(send_buffer, send_buffer_cnt);
     send_buffer_cnt = 0;

this will cause audio to be send to FRN as long as squelch is open even if state has been changed to IDLE.

M0IQF commented 5 years ago

I tried many times but it did not help (too little IT knowledge) - froze the whole program. Can someone give a QsoFrn.cpp file which is already reworked or get rid of the client list pickup ?

digit4all@gmail.com

M0IQF commented 4 years ago

Unfortunately it didn't help

__connecting to roip-polska.pl:10024 Tx1: Turning the transmitter ON login stage 1 completed: 2014000 login stage 2 completed: 2014004OKdigit4all.dyndns.org100243OeDU[OJYBu[cAXAAuLKtAIyROIP300N36733r6352-Linux-amd64 SimplexLogic: Sending short identification... Playing short voice ID WARNING: Could not find audio clip "phonetic_l" in context "Default" WARNING: Could not find audio clip "phonetic_n" in context "Default" WARNING: Could not find audio clip "phonetic_d" in context "Default" WARNING: Could not find audio clip "phonetic_0" in context "Default" WARNING: Could not find audio clip "phonetic_0" in context "Default" WARNING: Could not find audio clip "phonetic_1" in context "Default" FRN active client list updated FRN list received: -- 10Great BritainLuton - DunstableCrosslink0FRN-1.0, Analogowy2tPhJPJF8WiPn2FTs[CECgSoDASHBOARD -- 00AntarcticaCity - Street000.00000FM CTC131.81D4A000, prototyp3OeDU[OJYBu[cAXAAuLKtAIysvxlink klient FRN -- 00Great BritainLuton - DunstablePC Only2D4A000, MarcinlN[iZ57Y947XawmC72rUmgDIDEMO_USER FRN list received: -- Test -- Piaskownica -- ROIP -- Priv2 -- Priv4 Tx1: Turning the transmitter OFF Rx1: The squelch is OPEN (5.73119) FRN active client list updated FRN list received: -- 10Great BritainLuton - DunstableCrosslink0FRN-1.0, Analogowy2tPhJPJF8WiPn2FTs[CECgSoDASHBOARD -- 00AntarcticaCity - Street000.00000FM CTC131.81D4A000, prototyp3OeDU[OJYBu[cAXAAuLKtAIysvxlink klient FRN -- 20Great BritainLuton - Dunstable434.05000 FM1ECS000, MarcineQiqE3AdhHeX3dvBy4kNywA7D4A-MultiGateway -- 00Great BritainLuton - DunstablePC Only2D4A000, MarcinlN[iZ57Y947XawmC72rUmgDIDEMO_USER FRN active client list updated FRN list received: -- 10Great BritainLuton - DunstableCrosslink0FRN-1.0, Analogowy2tPhJPJF8WiPn2FTs[CECgSoDASHBOARD -- 00AntarcticaCity - Street000.00000FM CTC131.81D4A000, prototyp3OeDU[OJYBu[cAXAAuLKtAIysvxlink klient FRN -- 00Great BritainLuton - DunstablePC Only2D4A000, MarcinlN[iZ57Y947XawmC72rUmgDIDEMO_USER << CUT AUDIO TRANSMIT >>

When i'm TX , another client left the channel and connected again = and audio CUT

I'm not a specialist, but I think this is a problem

FRN active client list updated FRN list received:

Can we like AlterFRN completely do not receive this information?

f5vmr commented 4 years ago

The major problem here is in the sounds folder. If you have downloaded en_US Heather from the source on svxlink.org,  it is far from finished and contains many errors in respect of the structure and format of the .wav files. I have sent you a personal email, so check your spam filter if you cannot see it.If you are making files in your own language the 12th byte of the file must be changed from Hex 12 to Hex 10, and this can only best be done by importing any sample into Audacity, removing any empty spaces and highlighting the rest "EXPORTING" the portion as a Microsoft .wav, this will do the trick, and SVXLink will happily play them.I have created fr_FR and en_GB in full but I cannot publish these for general circulation as there may be licencing issues if they are released as a package. ;) ;) ;) Chris Jackson05.55.64.84.2006.68.70.87.20 "The art of diplomacy in everything is completely understanding the others point of view, anticipating the response, and prospecting common ground.""L'art de la diplomatie dans tout est de comprendre complètement le point de vue des autres, d'anticiper la réponse et de rechercher une entente cordiale."envoyé : 13 juin 2020 à 03:13de : M0IQF notifications@github.comà : sm0svx/svxlink svxlink@noreply.github.comcc : Subscribed subscribed@noreply.github.comobjet : Re: [sm0svx/svxlink] svxlink - ModuleFrn client list (#429) Unfortunately it didn't help__connecting to roip-polska.pl:10024 Tx1: Turning the transmitter ON login stage 1 completed: 2014000 login stage 2 completed: 2014004OKdigit4all.dyndns.org100243OeDU[OJYBu[cAXAAuLKtAIyROIP300N36733r6352-Linux-amd64 SimplexLogic: Sending short identification... Playing short voice ID WARNING: Could not find audio clip "phonetic_l" in context "Default" WARNING: Could not find audio clip "phonetic_n" in context "Default" WARNING: Could not find audio clip "phonetic_d" in context "Default" WARNING: Could not find audio clip "phonetic_0" in context "Default" WARNING: Could not find audio clip "phonetic_0" in context "Default" WARNING: Could not find audio clip "phonetic_1" in context "Default" FRN active client list updated FRN list received: -- 10Great BritainLuton - DunstableCrosslink0FRN-1.0, Analogowy2tPhJPJF8WiPn2FTs[CECgSoDASHBOARD -- 00AntarcticaCity - Street000.00000FM CTC131.81D4A000, prototyp3OeDU[OJYBu[cAXAAuLKtAIysvxlink klient FRN -- 00Great BritainLuton - DunstablePC Only2D4A000, MarcinlN[iZ57Y947XawmC72rUmgDIDEMO_USER FRN list received: -- Test -- Piaskownica -- ROIP -- Priv2 -- Priv4 Tx1: Turning the transmitter OFF Rx1: The squelch is OPEN (5.73119) FRN active client list updated FRN list received: -- 10Great BritainLuton - DunstableCrosslink0FRN-1.0, Analogowy2tPhJPJF8WiPn2FTs[CECgSoDASHBOARD -- 00AntarcticaCity - Street000.00000FM CTC131.81D4A000, prototyp3OeDU[OJYBu[cAXAAuLKtAIysvxlink klient FRN -- 20Great BritainLuton - Dunstable434.05000 FM1ECS000, MarcineQiqE3AdhHeX3dvBy4kNywA7D4A-MultiGateway -- 00Great BritainLuton - DunstablePC Only2D4A000, MarcinlN[iZ57Y947XawmC72rUmgDIDEMO_USER FRN active client list updated FRN list received: -- 10Great BritainLuton - DunstableCrosslink0FRN-1.0, Analogowy2tPhJPJF8WiPn2FTs[CECgSoDASHBOARD -- 00AntarcticaCity - Street000.00000FM CTC131.81D4A000, prototyp3OeDU[OJYBu[cAXAAuLKtAIysvxlink klient FRN -- 00Great BritainLuton - DunstablePC Only2D4A000, MarcinlN[iZ57Y947XawmC72rUmgDIDEMO_USERI'm not a specialist, but I think this is a problemFRN active client list updated FRN list received:Can we like AlterFRN completely do not receive this information?—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

M0IQF commented 4 years ago

DEBUG file http://roip-polska.pl/frn-debug.txt

DEBUG + VIDEO http://roip-polska.pl/svxlink-problem-frnmodule.html

DEBUG - new install + mod http://roip-polska.pl/frn-debug2.txt

valerysvl commented 2 years ago

Inserting into FRN handshake string tag < CEF >1< /CEF> will turn off the whole list of clients from AlterFRN server http://alterfrn.ucoz.ru/index/standalone_frn_server/0-24