sm0svx / svxlink

Advanced repeater system software with EchoLink support for Linux including a GUI, Qtel - the Qt EchoLink client
http://svxlink.org/
Other
435 stars 173 forks source link

Refresh echolink directory server information before rejecting the incoming connection #93

Closed dranch closed 9 years ago

dranch commented 10 years ago

From time to time, I see people trying to connect to me but Svxlink refuses to allow the connect:

*** WARNING: Ignoring incoming connection from WA6TJQ since the IP address
registered in the directory server (199.68.199.69) is not the same as the
remote IP address (199.68.199.63) of the incoming connection

Per Tobias on the svxlink-devel list:

I would not recommend this (using "ALLOW_IP=0.0.0.0/0") since anyone can connect. No EchoLink registration is required. The ALLOW_IP option was added to allow connections on an internal private network.

I believe the correct solution is to refresh the directory server information before rejecting the connection. It's probably the cached information that is wrong, not the information in the EchoLink directory servers.

brettwi commented 10 years ago

Has anyone a fix for this issue? This pretty much makes the entire system unusable since I primarily want to use svxlink as an Echolink server to my repeater. I can connect once from my android or iPhone and after that never again. This is not the case with other Echolink repeaters. Only svxlink? Any thoughts would save this system. How can I make svxlink refresh the directory server information before each connection?

sm0svx commented 10 years ago

Unfortunatelly you cannot make SvxLink refresh without changing the code. I think it should be rather straight forward to do though. If I can find the time I'll have a look at it.

sm0svx commented 10 years ago

I have implemented a small fix now which may solve the problem. You need to test it using the code from Git:

git clone https://github.com/sm0svx/svxlink
git checkout issue93

Build as usual and test it. You will still get a warning but hopefully a connection will be established on the next connection retry.

dranch commented 10 years ago

Hey Tobias,

Thanks for working on this and I'll give it a try. Curious, why is this on a private branch vs. the current master or develop branch?

--David

On 09/19/2014 01:03 PM, Tobias Blomberg wrote:

I have implemented a small fix now which may solve the problem. You need to test it using the code from Git:

git clone https://github.com/sm0svx/svxlink git checkout issue93

Build as usual and test it. You will still get a warning but hopefully a connection will be established on the next connection retry.

— Reply to this email directly or view it on GitHub https://github.com/sm0svx/svxlink/issues/93#issuecomment-56227325.

sm0svx commented 10 years ago

I try to do all development in branches and only merge the branch when it is known to work reasonably well. I could not reproduce this problem myself so I cannot confirm that it will solve the problem.

The develop branch has been discontinued. The master branch is now the bleeding edge branch. The latest release will always be available in the maint branch. More details in this post:

http://sourceforge.net/p/svxlink/mailman/message/32828220/

sm0svx commented 10 years ago

Have you had time to test this? If it works, I'd like to merge it to the master branch.

dranch commented 10 years ago

Hello Tobias,

Not quite as I've been plugging away on an APRS project. Let me see if I can get to it this weekend but looking at the diff, it doesn't look like there is much risk in just merging it.

--David

On 09/30/2014 12:42 PM, Tobias Blomberg wrote:

Have you had time to test this? If it works, I'd like to merge it to the master branch.

— Reply to this email directly or view it on GitHub https://github.com/sm0svx/svxlink/issues/93#issuecomment-57370697.

granitepenguin commented 9 years ago

Using branch issue93 appears to work.

Wed Apr 29 13:07:59 2015: SvxLink v1.4.99.0 (Apr 29 2015) Copyright (C) 2003-2014 Tobias Blomberg / SM0SVX

I still see a few of these errors (8 in this case, only 2 in another):

Wed Apr 29 13:12:27 2015: *\ WARNING: Ignoring incoming connection from K9DWR since the IP address registered in the directory server (107.23.11.57) is not the same as the remote IP address (107.23.158.3) of the incoming connection

But instead of it continuing to do that, it now continues as expected and eventually connects with the new IP address:

Wed Apr 29 13:12:27 2015: Spurious audio packet received from 107.23.158.3 Wed Apr 29 13:12:29 2015: Incoming EchoLink connection from K9DWR (David) at 107.23.158.3 Wed Apr 29 13:12:29 2015: EchoLink: Using GSM codec only Wed Apr 29 13:12:29 2015: SimplexLogic: Activating module EchoLink...