sm64pc / sm64ex

Fork of https://github.com/sm64-port/sm64-port with additional features.
1.54k stars 473 forks source link

Project does not build with DISCORDRPC=1 #559

Open nolemretaWxd opened 1 month ago

nolemretaWxd commented 1 month ago

Describe the bug Project doesn't compile on Linux

To Reproduce Steps to reproduce the behavior:

  1. make BETTERCAMERA=1 EXTERNAL_DATA=1 EXT_OPTIONS_MENU=1 TEXTSAVES=1 -j6
  2. Building will fail with error if DISCORDRPC is set to 1
    /usr/bin/ld: build/us_pc/src/pc/discord/discordrpc.o: in function `discord_update_rich_presence':
    discordrpc.c:(.text+0x322): undefined reference to `configDiscordRPC'
    /usr/bin/ld: build/us_pc/src/pc/discord/discordrpc.o: in function `discord_init':
    discordrpc.c:(.text+0x427): undefined reference to `configDiscordRPC'

    or

    /usr/bin/ld: build/us_pc/src/pc/pc_main.o: in function `game_deinit':
    pc_main.c:(.text+0x445): undefined reference to `discord_shutdown'
    /usr/bin/ld: build/us_pc/src/pc/pc_main.o: in function `main_func':
    pc_main.c:(.text+0x5ed): undefined reference to `discord_init'
    /usr/bin/ld: pc_main.c:(.text+0x61e): undefined reference to `discord_update_rich_presence'

    if not

Expected behavior Project should build

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

nolemretaWxd commented 1 month ago

Updated description because it does not compile at all, but it's the same failure as with DISCORDRPC=1

fgsfdsfgs commented 1 month ago

Did you make clean before building with different build options?

nolemretaWxd commented 1 month ago

Did you make clean before building with different build options?

It did not work for me before but works now. Still, there's an issue with building with Discord RPC enabled

fgsfdsfgs commented 1 month ago

I cannot reproduce this. You should clean build with all the options at once. If you change the options without cleaning first, build will fail because some objects from the previous build will be stuck in the build folder.

nolemretaWxd commented 1 month ago

I cannot reproduce this. You should clean build with all the options at once. If you change the options without cleaning first, build will fail because some objects from the previous build will be stuck in the build folder.

I tried, I also tried deleting local copy and cloning repository again.