search

smack-team / smack

Smack userspace
GNU Lesser General Public License v2.1
41 stars 33 forks source link

libsmack: add functions for setting and removing labels on files #98

Closed rafal-krypa closed 10 years ago

rafal-krypa commented 10 years ago

Functions smack_set_label_for_path and smack_remove_label_for_path have been added as private to chsmack code in version 1.0.4. Since they are generally useful, they should be exported in libsmack 1.1. Moving code from chsmack to libsmack.

rafal-krypa commented 10 years ago

Side note: having this in Tizen would help in dropping smack_getlabel()/smack_setlabel() stuff. @jsakkine, what's your opinion on using v1.1 in Tizen 3?

jarkkojs commented 10 years ago

I would rather discuss about 1.1 in the mailing list but it can be considered.

jarkkojs commented 10 years ago

I would suggest to do this top-down. I can take AR to make a proposal about new API in the mailing list and let's agree on that. Then come the patches. Then we can release v1.1. But you are right in that we know at this point quite well already what we need for 1.1 API.

rafal-krypa commented 10 years ago

Is there a documented procedure that you'd like to have for API changes? I'm not sure how would you like to handle it and maybe I have missed some guidelines.

jarkkojs commented 10 years ago

I think I can merge these but I'm not yet sure about part why I should release libsmack 1.1 and I would rather talk about that in the mailing list.