search

smacke / ffsubsync

Automagically synchronize subtitles with video.
MIT License
6.78k stars 281 forks source link

Subsync won't keep original subtitle encoding on synchronized one #23

Closed javad94 closed 5 years ago

javad94 commented 5 years ago

Hi, Thanks for this interesting command line tool. There is one bug that makes a problem when using this tool on languages like Persian. When synchronizing Persian subtitle, it doesn't preserve encoding of the original file, which make the synchronized subtitle unusable.

cmd_2019-03-08_15-34-49
smacke commented 5 years ago

Hi there,

Thanks for bringing this to my attention. With the latest changes in 38fda02884b1583b35a42e3b9633315b6c7b5a16, the input encoding should be preserved in the output. Additionally, you can manually specify the input encoding using the --encoding flag (by default it tries to infer from a fixed set).

If you grab the latest via pip install git+https://github.com/smacke/subsync, it should be fixed.

Please let me know if this doesn't fix your particular case and I'll try further; supporting as many languages as possible is a priority.

Best, Stephen

javad94 commented 5 years ago

Great, thank you. It's work as expected now.

smacke commented 5 years ago

Awesome! Thanks for letting me know.