search

smacke / ffsubsync

Automagically synchronize subtitles with video.
MIT License
6.74k stars 278 forks source link

Cannot use `--make-test-case` with `--overwrite-input` #91

Closed morpheus65535 closed 4 years ago

morpheus65535 commented 4 years ago

https://github.com/smacke/ffsubsync/blob/997749de8aac74ec19137a2e641b97ef1bba81ea/ffsubsync/ffsubsync.py#L205

shouldn't it be:

if args.srtin is None or (args.srtout is None and args.overwrite_input is None):

morpheus65535 commented 4 years ago

As args.strout is required down the road to copy it to the tar.gz archive, we cannot use args.overwrite_input with --make-test-case. I finally had to make a temporary output file and, when sync succeed, delete original and rename synced subtitles.