smacke / ffsubsync

Automagically synchronize subtitles with video.
MIT License
6.74k stars 278 forks source link

--make-test-case cannot work on Windows #92

Closed morpheus65535 closed 4 years ago

morpheus65535 commented 4 years ago

You're trying to create a directory with colons in it's name. This is not possible under Windows OS.

https://github.com/smacke/ffsubsync/blob/master/ffsubsync/ffsubsync.py#L42-L45

morpheus65535 commented 4 years ago

Ive replaced colons in hour with dash and it works perfectly fine. Would it be possible to remove the empty directory once the tar.gz file is created?

smacke commented 4 years ago

Hi @morpheus65535, thanks for catching this. By remove the empty directory, are you referring to tar_dir in the linked code? I thought it should get removed here: https://github.com/smacke/ffsubsync/blob/997749de8aac74ec19137a2e641b97ef1bba81ea/ffsubsync/ffsubsync.py#L71

morpheus65535 commented 4 years ago

It never get there in my case... is that properly indented?

https://github.com/smacke/ffsubsync/blob/997749de8aac74ec19137a2e641b97ef1bba81ea/ffsubsync/ffsubsync.py#L65-L68

morpheus65535 commented 4 years ago

Fixed by #97

smacke commented 4 years ago

Thank you!